Don't consider tag refs as valid for branch name#11847
Merged
Merged
Conversation
lafriks
approved these changes
Jun 10, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Jun 10, 2020
Contributor
zeripath
left a comment
zeripath
left a comment
There was a problem hiding this comment.
I umm'd and ahh'd about this one and whether we should be stricter to the point of using --refs refs/head/* instead but I guess this way we get to keep the refs/pulls/x/head references etc.
GiteaBot
added
lgtm/done
Contributor
Author
|
Yes it's a rather ugly case. Maybe treat pulls in special fashion, with different icon and display them separately? |
Contributor
Author
|
The issue is however - I'm not sure if we can remove pull refs from that function because of usage in |
Contributor
|
Exactly I think this is the minimal fix that doesn't break things (further) and fixes the tag problem. I suspect that the other cases are not bad things to show eg. If using git-as-svn then SVN commit refs should show up too |
Member
|
ping LG-TM |
8 tasks
This was referenced Jul 28, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name-revdoes not discriminate so we need to explicitly ensure that tags won't be taken into account