Fix sticky diff stats container#12002
Merged
Merged
Conversation
Member
|
Not a huge fan of JS-based sticky implementations as CSS |
GiteaBot
added
the
lgtm/need 2
Contributor
Author
|
We are using Fomantic sticky element however, so no, it is not. |
Contributor
Author
|
A quick test show that seem to work. Should we stop using Fomantic's sticky element in that case? |
silverwind
reviewed
Jun 21, 2020
Member
|
Good call removing the sticky module, thanks. |
silverwind
approved these changes
Jun 21, 2020
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
Member
|
ping lg-tm bot |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Fix sticky diff stats container * Use pure CSS sticky instead of Fomantic's JS * add border color to arc-green * add slight padding on sides * make linter happy Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pure CSS
position: stickyand disable Fomantic sticky componentThe border is applied always because there isn't any way to check if element is stuck or not without delegating to JS.