Skip to content

Use custom SVGs for commit signing lock icon#12017

Merged
techknowlogick merged 6 commits into
go-gitea:masterfrom
CirnoT:gpg-sign-lock-svg
Jun 28, 2020
Merged

Use custom SVGs for commit signing lock icon#12017
techknowlogick merged 6 commits into
go-gitea:masterfrom
CirnoT:gpg-sign-lock-svg

Conversation

@CirnoT
Copy link
Copy Markdown
Contributor

@CirnoT CirnoT commented Jun 22, 2020

chrome_2020-06-22_16-59-59
chrome_2020-06-22_17-00-34
chrome_2020-06-22_17-01-00
chrome_2020-06-22_17-01-47
chrome_2020-06-22_17-03-37
chrome_2020-06-22_17-03-52
chrome_2020-06-22_17-04-18
chrome_2020-06-22_17-04-34

@silverwind
Copy link
Copy Markdown
Member

Add this to .editorconfig:

[*.svg]
insert_final_newline = false

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 22, 2020
Comment thread assets/svg/gitea-lock-cog.svg Outdated
Comment thread assets/svg/gitea-lock.svg Outdated
Comment thread assets/svg/gitea-unlock.svg Outdated
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Jun 22, 2020
@lafriks lafriks added this to the 1.13.0 milestone Jun 22, 2020
@silverwind
Copy link
Copy Markdown
Member

xmlns is not necessary for inline SVG content, you can remove it.

@CirnoT
Copy link
Copy Markdown
Contributor Author

CirnoT commented Jun 22, 2020

Copying SVG inline from octicons primer website generates it so I've also added it. Also for some reason this allows GoLand to show image preview, for what it's worth.

@silverwind
Copy link
Copy Markdown
Member

Yeah it's needed for standalone display. It seems svg-sprite-loader already removes the attribute, so it should be fine.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 22, 2020
margin-right: 0;
}

.svg {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this change?

Copy link
Copy Markdown
Contributor Author

@CirnoT CirnoT Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add proper margin on the right of svg inside flex container

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2020
@techknowlogick
Copy link
Copy Markdown
Member

ping LG-TM

@techknowlogick techknowlogick merged commit b918609 into go-gitea:master Jun 28, 2020
@CirnoT CirnoT deleted the gpg-sign-lock-svg branch June 28, 2020 12:08
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
* Use custom SVGs for commit signing lock icon

* missing spans

* editorconfig

* xmlns and remove aria-hidden

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants