Fix repo API listing stability #12057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As noted in the Issue I'm not sure this is a complete fix as other API pagination methods may have similar problems. I'm also in the process of getting this tested properly locally, but I wanted to get this up so that others could offer suggestions or additional fixes if necessary. |
GiteaBot
added
the
lgtm/need 2
|
I'm doing more testing locally and I'm not sure this fixes the issue for us yet. In any case it should serve as a starting point for figuring it out. |
lunny
approved these changes
Jun 27, 2020
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Jun 28, 2020
GiteaBot
added
lgtm/done
Repo listings are paginated in the API now. Unfortunately, they are ORDER BY updated_unix which only has second resolution. This means that if you do a listing when multiple projects were created at the same time you can unstable ordering. If that unstable ordering happens at a page boundary you may fail to get a complete repo listing. To make things worse sorting by updated_unix means that we may never get a complete listing because udpated_unix can change independent of our API calls. Fix this by making the API repo listing order by id instead.
cboylan
force-pushed
the
fix-repo-list-stability
branch
from
57bbb30 to
a67f21c
Compare
|
New version does and ascending not descending sort. I realized that if a new repo is added during a listing we'll get that inserted at the front not the end using descending. If we use ascending it will be added at the end and a user paging through the list will see the new repo. In the end both should work, but ascending is a bit more friendly I think. |
lafriks
approved these changes
Jun 28, 2020
|
make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Repo listings are paginated in the API now. Unfortunately, they are ORDER BY updated_unix which only has second resolution. This means that if you do a listing when multiple projects were created at the same time you can unstable ordering. If that unstable ordering happens at a page boundary you may fail to get a complete repo listing. To make things worse sorting by updated_unix means that we may never get a complete listing because udpated_unix can change independent of our API calls. Fix this by making the API repo listing order by id instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #12056
Repo listings are paginated in the API now. Unfortunately, they are
ORDER BY updated_unix which only has second resolution. This means that
if you do a listing when multiple projects were created at the same time
you can unstable ordering. If that unstable ordering happens at a page
boundary you may fail to get a complete repo listing.
To make things worse sorting by updated_unix means that we may never get
a complete listing because udpated_unix can change independent of our
API calls.
Fix this by making the API repo listing order by id instead.