Fix U2F button icon#12167
Merged
Merged
Conversation
Contributor
|
Wouldn't it be better to replace it with something else? Possibly https://primer.style/octicons/key-16 |
GiteaBot
added
the
lgtm/need 2
Member
Author
|
Okay, did that and also fixed the button color on arc-green (it only styles green buttons, not positive ones).
|
Previously this used a USB icon which required a separate font file used nowhere else so replace it with a octicon and fix the background color on arc-green too.
techknowlogick
approved these changes
Jul 6, 2020
GiteaBot
added
lgtm/need 1
techknowlogick
added
type/bug
topic/ui
lafriks
approved these changes
Jul 6, 2020
GiteaBot
added
lgtm/done
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Previously this used a USB icon which required a separate font file used nowhere else so replace it with a octicon and fix the background color on arc-green too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I assumed the file being unused but it's apparently in use on the "Add Security Key" button where a USB icon is shown.
@CirnoT please confirm if possible.