In issue comments, put issue participants also in completion list when hitting @#12433
Merged
zeripath merged 2 commits intoAug 5, 2020
Merged
Conversation
…n hitting @ Previous behaviour was only to have completion for project members
silverwind
approved these changes
Aug 5, 2020
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Aug 5, 2020
GiteaBot
added
lgtm/done
Contributor
|
I suspect that these really need to be generated from some sort of ajax call but this is reasonable. |
Member
|
Yes, some better mechanism to propate values to JS (like localization) would be nice but it's kind of a hard problem to solve because ajax calls introduce unnecessary delay. Maybe a lightweight second script that runs before index.js that does just that, but it's a extra round trip in any case using ajax. |
Contributor
|
Make lg-tm work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behaviour was only to have completion for project members.
This combines participant lists with the possible assignee lists and removes duplicates.
Duplicate removal is done on the javascript side. It would be probably cleaner to create the list in go code, but this keeps the patch minimal.