Skip to content

Add SVG favicon#12437

Merged
zeripath merged 2 commits into
go-gitea:masterfrom
silverwind:svgfav
Aug 6, 2020
Merged

Add SVG favicon#12437
zeripath merged 2 commits into
go-gitea:masterfrom
silverwind:svgfav

Conversation

@silverwind
Copy link
Copy Markdown
Member

Browser support is pretty good and the .png icon should still continue to work in unsupporting browser.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 5, 2020
@silverwind
Copy link
Copy Markdown
Member Author

Should probably call out in the release notes that users who customize the icon have to provide favicon.svg (ideally generated along other images using make generate-images).

@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Aug 5, 2020
@zeripath zeripath added this to the 1.13.0 milestone Aug 5, 2020
@zeripath zeripath added the release/highlight Marks a PR as a highlight-worthy change for the release notes. label Aug 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 6, 2020
@zeripath
Copy link
Copy Markdown
Contributor

zeripath commented Aug 6, 2020

Make lg-tm work

@zeripath zeripath merged commit f1a42f5 into go-gitea:master Aug 6, 2020
@silverwind silverwind deleted the svgfav branch August 6, 2020 07:25
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
@delvh delvh removed the release/highlight Marks a PR as a highlight-worthy change for the release notes. label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants