Skip to content

Add email notify for new release#12463

Merged
zeripath merged 13 commits into
go-gitea:masterfrom
a1012112796:release_emaila
Aug 23, 2020
Merged

Add email notify for new release#12463
zeripath merged 13 commits into
go-gitea:masterfrom
a1012112796:release_emaila

Conversation

@a1012112796
Copy link
Copy Markdown
Member

@a1012112796 a1012112796 commented Aug 9, 2020

Add email notify for new release

example view:

tmp

@a1012112796 a1012112796 changed the title Release emaila Add email notify for new release Aug 9, 2020
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 9, 2020
@lunny lunny added this to the 1.13.0 milestone Aug 9, 2020
@lunny
Copy link
Copy Markdown
Member

lunny commented Aug 9, 2020

It's only for public repository. For private repository link, we need another PRs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 9, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #12463 into master will increase coverage by 0.02%.
The diff coverage is 76.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12463      +/-   ##
==========================================
+ Coverage   43.42%   43.44%   +0.02%     
==========================================
  Files         643      644       +1     
  Lines       71165    71203      +38     
==========================================
+ Hits        30904    30935      +31     
- Misses      35254    35258       +4     
- Partials     5007     5010       +3
Impacted Files Coverage Δ
models/release.go 54.69% <ø> (ø)
modules/notification/mail/mail.go 34.48% <57.14%> (+1.98%) ⬆️
services/mailer/mail_release.go 80.64% <80.64%> (ø)
modules/indexer/stats/queue.go 52.94% <0.00%> (-23.53%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/git/blame.go 75.43% <0.00%> (-1.76%) ⬇️
models/issue_comment.go 53.90% <0.00%> (+0.15%) ⬆️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/git/repo.go 49.74% <0.00%> (+0.50%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e429c11...8bce5b3. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 12, 2020
@mrsdizzie mrsdizzie mentioned this pull request Aug 20, 2020
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 22, 2020
@zeripath zeripath merged commit e7d65cb into go-gitea:master Aug 23, 2020
@a1012112796 a1012112796 deleted the release_emaila branch August 23, 2020 15:04
@mrsdizzie mrsdizzie mentioned this pull request Sep 7, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

7 participants

@a1012112796 @lunny @codecov-commenter @lafriks @zeripath @GiteaBot @techknowlogick