Keys should not verify revoked email addresses (#12486)#12495
Merged
Conversation
Backport go-gitea#12486 Fix go-gitea#6778 Signed-off-by: Andrew Thornton <art27@cantab.net>
Contributor
Author
|
It's worth noting that this will only result in non-verification if and only if the key does not match any other email address for the user. (Remember that Signature Verification in Gitea does not currently match Github - Github's signature verification is only committer verification we have a slightly different model.) |
GiteaBot
added
the
lgtm/need 2
techknowlogick
approved these changes
Aug 16, 2020
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Aug 17, 2020
GiteaBot
added
lgtm/done
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #12486
Fix #6778
Signed-off-by: Andrew Thornton art27@cantab.net