Ensure that the detected charset order is set in chardet test (#12574)#12578
Closed
zeripath wants to merge 1 commit into
Closed
Ensure that the detected charset order is set in chardet test (#12574)#12578zeripath wants to merge 1 commit into
zeripath wants to merge 1 commit into
Conversation
…ea#12574) Backport go-gitea#12574 TestToUTF8WithFallback is the cause of recurrent spurious test failures even despite code to set the detected charset order. The reason why this happens is because the preferred detected charset order is not being initialised for these tests. This PR simply ensures that this is set at the start of each test and would allow different tests to be written to allow differing orders. Replaces go-gitea#12571 Close go-gitea#12571 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
topic/build
silverwind
approved these changes
Aug 23, 2020
GiteaBot
added
the
lgtm/need 1
Member
|
Seems to fail the linter. |
Contributor
Author
|
#11621 does not appear to be in 1.12 - sorry peeps can't backport this fix to 1.12... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #12574
TestToUTF8WithFallback is the cause of recurrent spurious test failures
even despite code to set the detected charset order.
The reason why this happens is because the preferred detected charset order
is not being initialised for these tests.
This PR simply ensures that this is set at the start of each test and would
allow different tests to be written to allow differing orders.
Replaces #12571
Close #12571
Signed-off-by: Andrew Thornton art27@cantab.net