Skip to content

File header tweaks, add CSS helpers #12635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2020
Merged

File header tweaks, add CSS helpers #12635

merged 3 commits into from
Sep 8, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Aug 29, 2020 •
edited
Loading

  • replace two instances of fontawesome with octicons
  • add new "class" optional argument to "svg" helper
  • add many new CSS helpers and move their import to the end for increased precedence

Screen Shot 2020-08-29 at 14 00 47

Screen Shot 2020-08-29 at 13 58 27

@silverwind silverwind changed the title File header tweaks File header tweaks, add CSS helpers Aug 29, 2020
silverwind
silverwind commented Aug 29, 2020
View reviewed changes
templates/repo/view_file.tmpl Outdated
{{else}}
<i class="book icon"></i>
{{end}}
{{svg "octicon-book" 16 "mr-2"}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was rendering a book with a overlayed link in case a readme was a symlink. Given that there is no equivalent octicon and symlinked readme is rather rare, I decided to remove this and always render a book.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 29, 2020
@silverwind
File header tweaks, add CSS helpers
4c14d1f 
- replace two instances of fontawesome with octicons
- add new "class" optional argument to "svg" helper
- add many new CSS helpers and move their import to the end for
  increaseed precedence
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 7, 2020
@CirnoT
Copy link
Contributor

CirnoT commented Sep 7, 2020

Changes look OK, unsure about failing tests?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 7, 2020
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 8, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 8, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 3865ecb into go-gitea:master Sep 8, 2020
@silverwind silverwind deleted the more-octicons branch September 8, 2020 18:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CirnoT CirnoT CirnoT approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @CirnoT @techknowlogick @zeripath @GiteaBot