[API] Milestone endpoints accept names too

[6543]

similar to #12366 but for milestones

is very usefull for https://gitea.com/gitea/go-sdk/pulls/388 ... and so on

[codecov-commenter]

Codecov Report

Merging #12649 into master will increase coverage by 0.01%.
The diff coverage is 48.27%.

@@            Coverage Diff             @@
##           master   #12649      +/-   ##
==========================================
+ Coverage   43.15%   43.17%   +0.01%     
==========================================
  Files         654      654              
  Lines       72205    72218      +13     
==========================================
+ Hits        31159    31179      +20     
+ Misses      35998    35986      -12     
- Partials     5048     5053       +5     

Impacted Files	Coverage Δ
modules/indexer/code/bleve.go	71.16% <ø> (-0.27%)	⬇️
routers/api/v1/repo/milestone.go	57.69% <46.15%> (+3.84%)	⬆️
modules/indexer/code/indexer.go	35.95% <66.66%> (+0.72%)	⬆️
modules/indexer/stats/db.go	52.17% <0.00%> (-8.70%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
modules/git/repo.go	49.74% <0.00%> (-0.51%)	⬇️
services/pull/pull.go	41.57% <0.00%> (-0.47%)	⬇️
models/gpg_key.go	55.40% <0.00%> (+0.58%)	⬆️
routers/repo/view.go	38.11% <0.00%> (+0.64%)	⬆️
modules/log/event.go	59.43% <0.00%> (+1.88%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f606c...51ebde6. Read the comment docs.

[6543]

as per @lafriks lable kind/breanking needed

[6543]

@zeripath renamed
But If I remove ctx from this function, I'll have to handle Errors in a seperat function (if dont like to create duplicated code) witch relay on ctx then

[CirnoT]

I really wonder if this is necessary to implement; the API does not need to act via name for user convenience because it's not designed for that, and CLI utility can implement a very simple logic to fetch ID and names mappings from API. This would also allow CLI to perform some interesting resolve mechanism, such as:

• 1 -> ID
• "1" -> name
• kind/breaking -> name
• "kind/breaking" -> name

What do you say @6543, wouldn't this be better abstracted from main Gitea code?

[6543]

@CirnoT "resolving" the milestone by name was called "low efficient" so I go this way around
and indeed will this end up in one api call instead of 2

[CirnoT]

It might be easiest, but are we really going to support this for every single API that takes ID?

[6543]

@CirnoT otherwise we have to do this on client side:

// ResolveMilestoneIDByName is a fallback method to find milestone id by name
func (c *Client) ResolveMilestoneIDByName(owner, repo, name string) (int64, error) {
	i := 0
	for {
		i++
		miles, err := c.ListRepoMilestones(owner, repo, ListMilestoneOption{
			ListOptions: ListOptions{
				Page: i,
			},
			State: "all",
			Name: name,
		})
		if err != nil {
			return 0, err
		}
		if len(miles) == 0 {
			return 0, fmt.Errorf("milestone '%s' do not exist", name)
		}
		for _, m := range miles {
			if strings.ToLower(strings.TrimSpace(m.Title)) == strings.ToLower(strings.TrimSpace(name)) {
				return m.ID, nil
			}
		}
	}
}

[6543]

It might be easiest, but are we really going to support this for every single API that takes ID?

@CirnoT only if it realy make sence (to lower api requests) I would say

[lafriks]

🚀