Set avatar image dimensions#12654
Merged
Merged
Conversation
Set the avatar image dimensions to help browsers avoid layout reflows. Helps page load performance and user experience (less content jank).
Codecov Report
@@ Coverage Diff @@
## master #12654 +/- ##
=======================================
Coverage 43.28% 43.28%
=======================================
Files 646 646
Lines 71625 71625
=======================================
+ Hits 31002 31006 +4
+ Misses 35608 35602 -6
- Partials 5015 5017 +2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Aug 31, 2020
Member
|
Note for later: We should probably extract avatar rendering to a helper function, e.g. |
mrsdizzie
approved these changes
Aug 31, 2020
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the avatar image dimensions to help browsers avoid layout reflows. Helps page load performance and user experience (less content jank).
Here’s an animated PNG demonstrating the problem this patch solved. (This is Codebase.org’s theme, but the issue is generic.)