Set TLS minimum version to 1.2#12689
Merged
Merged
Conversation
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
topic/security
techknowlogick
approved these changes
Sep 2, 2020
Member
techknowlogick
left a comment
techknowlogick
left a comment
There was a problem hiding this comment.
Thanks for splitting up PR :)
GiteaBot
added
the
lgtm/need 1
6543
reviewed
Sep 2, 2020
Member
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
do this is need a opt out? Via app.ini ?
Member
As there is a way for users to use less secure way (reverse proxy in front of gitea configured with lower TLS version) I'm ok if we don't provide opt-out. |
Member
|
yes had that in mind too - just like to have a bit consent :) |
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #12689 +/- ##
==========================================
- Coverage 43.33% 43.33% -0.01%
==========================================
Files 645 645
Lines 71526 71527 +1
==========================================
Hits 30994 30994
- Misses 35516 35518 +2
+ Partials 5016 5015 -1
Continue to review full report at Codecov.
|
lunny
added
the
pr/breaking
Member
|
This is a breaking change we should mention on release notes. |
lafriks
added
the
release/highlight
delvh
removed
the
release/highlight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial of #10602
Changes to TLS
Currently, Gitea allows TLS 1.0 and TLS 1.1 for HTTPS connections. These versions of TLS have long been deprecated due to security vulnerabilities, and are also no longer necessary for wide browser compatibility. The change I propose in this pull request sets TLS 1.2 as the minimum TLS version, with additional support for TLS 1.3.
On SSLLabs, we can see the difference. Before the changes:
After the changes:
Closes #10602
Signed-off-by: Andrew Thornton art27@cantab.net