Skip to content

Add github api token option to generate-license & generate-gitignore #12700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 3, 2020

Continued from #12683.

Without providing the username and token both of these commands could be rate limited.

This PR provides a way of setting the username and token to be set over BASIC authentication to prevent rate limiting.

a1012112796 and others added 2 commits September 3, 2020 17:27
Without api toke, Will face rate limit sometimes.

Signed-off-by: a1012112796 <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #12700 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12700      +/-   ##
==========================================
- Coverage   43.31%   43.30%   -0.01%     
==========================================
  Files         646      646              
  Lines       71567    71567              
==========================================
- Hits        30997    30995       -2     
- Misses      35552    35556       +4     
+ Partials     5018     5016       -2     
Impacted Files Coverage Δ
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/log/event.go 56.60% <0.00%> (-1.89%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 42.72% <0.00%> (+1.15%) ⬆️
modules/git/blame.go 77.19% <0.00%> (+1.75%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
services/pull/update.go 57.69% <0.00%> (+5.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d745610...9a37722. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 3, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 3, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 4, 2020
@techknowlogick techknowlogick merged commit 4c557ef into go-gitea:master Sep 4, 2020
@zeripath zeripath deleted the redo-12683-gitignore-token branch September 4, 2020 16:54
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants