Check passwords against HaveIBeenPwned#12716
Merged
Merged
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
mrsdizzie
reviewed
Sep 4, 2020
Co-authored-by: mrsdizzie <info@mrsdizzie.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Member
Author
|
@mrsdizzie Done. I also added the link to the admin command. |
Codecov Report
@@ Coverage Diff @@
## master #12716 +/- ##
==========================================
- Coverage 43.25% 43.24% -0.01%
==========================================
Files 648 649 +1
Lines 71928 72000 +72
==========================================
+ Hits 31111 31137 +26
- Misses 35775 35819 +44
- Partials 5042 5044 +2
Continue to review full report at Codecov.
|
zeripath
reviewed
Sep 4, 2020
zeripath
reviewed
Sep 4, 2020
zeripath
reviewed
Sep 4, 2020
zeripath
reviewed
Sep 4, 2020
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Signed-off-by: jolheiser <john.olheiser@gmail.com>
zeripath
reviewed
Sep 5, 2020
zeripath
approved these changes
Sep 5, 2020
lafriks
reviewed
Sep 5, 2020
lafriks
reviewed
Sep 5, 2020
lafriks
reviewed
Sep 5, 2020
Member
Author
|
@lafriks Let me know if you still think they should be changed, but for the moment I've resolved the issues as HIBP capitalizes the URL part. |
mrsdizzie
approved these changes
Sep 8, 2020
Member
|
lgtm -- also wouldn't mind this being in 1.13 as a better alternative to the password complexity feature : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a way to check a password against HaveIBeenPwned.
Something to note, I made a decision to add padding to all requests for extra security. Since we are using the service solely to check passwords for a user (vs some automated security script), the added overhead should be fairly negligible.
You can read more about HaveIBeenPwned's padding here: https://haveibeenpwned.com/API/v3#PwnedPasswordsPadding