Skip to content

Set setting.AppURL as GITEA_ROOT_URL environment variable during pushes#12752

Merged
techknowlogick merged 3 commits into
go-gitea:masterfrom
zeripath:fix-11738-set-app-url-as-environment-variable
Sep 7, 2020
Merged

Set setting.AppURL as GITEA_ROOT_URL environment variable during pushes#12752
techknowlogick merged 3 commits into
go-gitea:masterfrom
zeripath:fix-11738-set-app-url-as-environment-variable

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Sep 6, 2020

Fix #11738

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath zeripath added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 6, 2020
Comment thread routers/repo/http.go
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2020
Comment thread routers/repo/http.go
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 6, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 6, 2020

Codecov Report

Merging #12752 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12752      +/-   ##
==========================================
- Coverage   43.30%   43.28%   -0.03%     
==========================================
  Files         648      648              
  Lines       71762    71765       +3     
==========================================
- Hits        31079    31064      -15     
- Misses      35654    35668      +14     
- Partials     5029     5033       +4     
Impacted Files Coverage Δ
cmd/serv.go 2.06% <0.00%> (-0.02%) ⬇️
models/helper_environment.go 93.33% <100.00%> (+0.22%) ⬆️
routers/repo/http.go 43.11% <100.00%> (+0.14%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-1.53%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/pull.go 41.57% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17efaa...12db238. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 7, 2020
@techknowlogick techknowlogick merged commit a722dd7 into go-gitea:master Sep 7, 2020
@techknowlogick techknowlogick added this to the 1.13.0 milestone Sep 7, 2020
@zeripath zeripath deleted the fix-11738-set-app-url-as-environment-variable branch September 7, 2020 06:11
@zeripath zeripath added type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Oct 14, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit URL environment variable

5 participants