Add default storage configurations

[lunny]

• Add default storage configurations
• Moved LFS storage configurations from LFS_* to under [lfs]
• Also includes some bugs of LFS path
• Fix bugs on dump related to Attachment and LFS
• Some break changes related to Attachment and LFS on recent PRs

[codecov-commenter]

Codecov Report

Merging #12813 into master will increase coverage by 0.03%.
The diff coverage is 30.38%.

@@            Coverage Diff             @@
##           master   #12813      +/-   ##
==========================================
+ Coverage   42.54%   42.58%   +0.03%     
==========================================
  Files         670      671       +1     
  Lines       73522    73627     +105     
==========================================
+ Hits        31281    31354      +73     
- Misses      37175    37188      +13     
- Partials     5066     5085      +19     

Impacted Files	Coverage Δ
cmd/dump.go	0.90% <0.00%> (-0.13%)	⬇️
cmd/migrate_storage.go	0.00% <0.00%> (ø)
models/admin.go	69.09% <0.00%> (-2.61%)	⬇️
models/repo.go	55.15% <0.00%> (+0.04%)	⬆️
modules/storage/minio.go	0.00% <0.00%> (-48.44%)	⬇️
routers/install.go	0.00% <0.00%> (ø)
routers/repo/lfs.go	0.00% <0.00%> (ø)
modules/storage/local.go	38.09% <5.88%> (-11.91%)	⬇️
modules/setting/storage.go	43.47% <43.47%> (ø)
modules/setting/attachment.go	64.28% <55.00%> (-16.67%)	⬇️
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6ac08...dcd73d1. Read the comment docs.

[lafriks]

We should probably prefix filenames with type (ex. lfs-, avatar-, repo-avatar- etc) so that all blobs can be stored in single bucket

[lunny]

This also fixes #12828

[lunny]

@lafriks MINIO_BASE_PATH will resolve the problem.

[zeripath]

Do we really need this?

This is a bad sign, we should be removing lint exceptions not adding them.

[lunny]

I removed

- path: modules/setting/attachment.go
      linters:
        - dupl
    - path: modules/setting/lfs.go
      linters:
        - dupl

but still keep cmd/dump.go because it reports the duplicated codes but I think merging them as a function is not a good choice.

[lunny]

@zeripath Merged.

[lafriks]

@lunny backend lint fails

[zeripath]

Why did you decide to prestash the storage configs here:

func getStorage(sec *ini.Section) Storage {
	var storage Storage
	storage.Type = sec.Key("STORAGE_TYPE").MustString(LocalStorageType)
	storage.Section = sec
	storage.ServeDirect = sec.Key("SERVE_DIRECT").MustBool(false)
	sec.Key("MINIO_ENDPOINT").MustString("localhost:9000")
	sec.Key("MINIO_ACCESS_KEY_ID").MustString("")
	sec.Key("MINIO_SECRET_ACCESS_KEY").MustString("")
	sec.Key("MINIO_BUCKET").MustString("gitea")
	sec.Key("MINIO_LOCATION").MustString("us-east-1")
	sec.Key("MINIO_USE_SSL").MustBool(false)
	return storage
}

func newStorageService() {
	sec := Cfg.Section("storage")
	storages["default"] = getStorage(sec)

	for _, sec := range Cfg.Section("storage").ChildSections() {
		name := strings.TrimPrefix(sec.Name(), "storage.")
		if name == "default" || name == LocalStorageType || name == MinioStorageType {
			log.Error("storage name %s is system reserved!", name)
			continue
		}
		storages[name] = getStorage(sec)
	}
}

Instead of following the pattern of

func GetStorageSettings(name string) { ... }

?

[lunny]

@zeripath because these configurations maybe inherit or override.

[lunny]

@zeripath Could you send your PR directly to gitea once this merged?

[zeripath]

looks like I'll have to