Skip to content

Use a simple format for the big number on ui#12822

Merged
techknowlogick merged 11 commits into
go-gitea:masterfrom
a1012112796:enhancement/number_format
Sep 16, 2020
Merged

Use a simple format for the big number on ui#12822
techknowlogick merged 11 commits into
go-gitea:masterfrom
a1012112796:enhancement/number_format

Conversation

@a1012112796
Copy link
Copy Markdown
Member

As title, It's same with GH.

@lunny lunny added the type/enhancement An improvement of existing functionality label Sep 13, 2020
@lunny lunny added this to the 1.14.0 milestone Sep 13, 2020
Comment thread modules/base/tool.go Outdated
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 13, 2020
Comment thread modules/base/tool.go Outdated
Comment thread modules/templates/helper.go Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #12822 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12822      +/-   ##
==========================================
+ Coverage   42.93%   43.10%   +0.16%     
==========================================
  Files         655      655              
  Lines       72329    72347      +18     
==========================================
+ Hits        31054    31182     +128     
+ Misses      36253    36113     -140     
- Partials     5022     5052      +30     
Impacted Files Coverage Δ
modules/templates/helper.go 47.26% <ø> (ø)
modules/base/tool.go 64.63% <100.00%> (+2.79%) ⬆️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
services/pull/pull.go 40.78% <0.00%> (ø)
models/pull.go 55.17% <0.00%> (+0.62%) ⬆️
services/mailer/mail.go 55.91% <0.00%> (+1.07%) ⬆️
modules/notification/notification.go 81.25% <0.00%> (+2.67%) ⬆️
modules/notification/base/null.go 71.42% <0.00%> (+2.85%) ⬆️
modules/git/commit.go 54.72% <0.00%> (+4.05%) ⬆️
modules/notification/mail/mail.go 34.48% <0.00%> (+5.74%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b5235...17201d6. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2020
@lunny lunny modified the milestones: 1.14.0, 1.13.0 Sep 16, 2020
@lunny
Copy link
Copy Markdown
Member

lunny commented Sep 16, 2020

I moved this to v1.13 since it's unnecessary to wait.

@techknowlogick techknowlogick merged commit a9decf0 into go-gitea:master Sep 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants