Skip to content

Add ui style for "Open a blank issue" button#12824

Merged
lunny merged 10 commits into
go-gitea:masterfrom
a1012112796:button_ui
Sep 16, 2020
Merged

Add ui style for "Open a blank issue" button#12824
lunny merged 10 commits into
go-gitea:masterfrom
a1012112796:button_ui

Conversation

@a1012112796
Copy link
Copy Markdown
Member

@a1012112796 a1012112796 commented Sep 13, 2020

From:
tmp1

To:
image

Signed-off-by: a1012112796 <1012112796@qq.com>
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label Sep 13, 2020
@silverwind
Copy link
Copy Markdown
Member

Certainly better than before but I think even better would be to move the button to the right, e.g. Blank Issue <whitespace> Get Started.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 13, 2020
@jolheiser
Copy link
Copy Markdown
Member

I believe the reason GH does it as a link is because users should be drawn to and encouraged to use the templates if present, rather than making a default issue.

But I am admittedly not a UI pro. 😅

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #12824 into master will decrease coverage by 0.01%.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12824      +/-   ##
==========================================
- Coverage   43.11%   43.10%   -0.02%     
==========================================
  Files         655      655              
  Lines       72328    72329       +1     
==========================================
- Hits        31186    31177       -9     
- Misses      36094    36108      +14     
+ Partials     5048     5044       -4     
Impacted Files Coverage Δ
routers/home.go 47.50% <0.00%> (+0.36%) ⬆️
models/notification.go 66.74% <57.14%> (-0.31%) ⬇️
models/repo.go 55.54% <80.00%> (-0.15%) ⬇️
routers/repo/repo.go 28.46% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/notification/mail/mail.go 34.48% <0.00%> (-3.45%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/log/event.go 56.60% <0.00%> (-1.89%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace8a28...9487384. Read the comment docs.

Comment thread templates/repo/issue/choose.tmpl Outdated
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Sep 14, 2020

encouraged to use the templates

We could maybe de-emphasize the button by making it gray (e.g. remove the green class), but I'm happy either way.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 14, 2020
Comment thread options/locale/locale_en-US.ini Outdated
@lafriks lafriks added this to the 1.13.0 milestone Sep 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 15, 2020
@lafriks
Copy link
Copy Markdown
Member

lafriks commented Sep 15, 2020

🚀

@6543
Copy link
Copy Markdown
Member

6543 commented Sep 15, 2020

this looks so mouch better

@lafriks
Copy link
Copy Markdown
Member

lafriks commented Sep 16, 2020

🚀

@lunny lunny merged commit d8b5235 into go-gitea:master Sep 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants