Skip to content

Fix notifications page links#12838

Merged
zeripath merged 4 commits into
go-gitea:masterfrom
zeripath:fix-notifications-page-links
Sep 15, 2020
Merged

Fix notifications page links#12838
zeripath merged 4 commits into
go-gitea:masterfrom
zeripath:fix-notifications-page-links

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

When you click read or pinned buttons on the notifications page - the page links become broken with an extraneous /status added.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 15, 2020

Codecov Report

Merging #12838 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12838      +/-   ##
==========================================
+ Coverage   43.15%   43.17%   +0.02%     
==========================================
  Files         654      654              
  Lines       72192    72193       +1     
==========================================
+ Hits        31152    31168      +16     
+ Misses      35990    35978      -12     
+ Partials     5050     5047       -3     
Impacted Files Coverage Δ
routers/user/notification.go 40.17% <0.00%> (-0.37%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/check.go 48.46% <0.00%> (-2.31%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
models/issue_comment.go 53.75% <0.00%> (-0.16%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
routers/repo/view.go 38.11% <0.00%> (+0.64%) ⬆️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 342e49e...edca3ce. Read the comment docs.

@zeripath zeripath merged commit d5e6211 into go-gitea:master Sep 15, 2020
@zeripath zeripath deleted the fix-notifications-page-links branch September 15, 2020 06:06
zeripath added a commit to zeripath/gitea that referenced this pull request Sep 15, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the backport/done All backports for this PR have been created label Sep 15, 2020
zeripath added a commit that referenced this pull request Sep 15, 2020
Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants