Skip to content

[API] NotificationSubject show Issue/Pull State#12901

Merged
techknowlogick merged 3 commits into
go-gitea:masterfrom
6543:api-notify-add-status
Sep 20, 2020
Merged

[API] NotificationSubject show Issue/Pull State#12901
techknowlogick merged 3 commits into
go-gitea:masterfrom
6543:api-notify-add-status

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Sep 19, 2020

as title

@6543 6543 added kind/api type/enhancement An improvement of existing functionality labels Sep 19, 2020
@6543 6543 added this to the 1.14.0 milestone Sep 19, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2020

Codecov Report

Merging #12901 into master will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12901      +/-   ##
==========================================
+ Coverage   42.96%   43.08%   +0.11%     
==========================================
  Files         658      658              
  Lines       72449    72451       +2     
==========================================
+ Hits        31127    31212      +85     
+ Misses      36282    36184      -98     
- Partials     5040     5055      +15     
Impacted Files Coverage Δ
models/notification.go 65.76% <50.00%> (-0.08%) ⬇️
routers/api/v1/org/org.go 61.11% <100.00%> (ø)
modules/util/remove.go 65.38% <0.00%> (-15.39%) ⬇️
models/repo_mirror.go 2.38% <0.00%> (-11.91%) ⬇️
modules/cron/tasks_basic.go 87.35% <0.00%> (-3.45%) ⬇️
modules/log/event.go 56.60% <0.00%> (-2.84%) ⬇️
services/mirror/mirror.go 18.58% <0.00%> (-1.36%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
services/pull/check.go 47.69% <0.00%> (+0.76%) ⬆️
services/pull/pull.go 41.27% <0.00%> (+0.98%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f9eb93...f5ec83a. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 19, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 20, 2020
@mrsdizzie mrsdizzie modified the milestones: 1.14.0, 1.13.0 Sep 20, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Sep 20, 2020

🚀

@techknowlogick techknowlogick merged commit 2dbca92 into go-gitea:master Sep 20, 2020
@6543 6543 deleted the api-notify-add-status branch September 20, 2020 23:15
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants