Skip to content

Add config option to make create-on-push repositories public by default#12936

Merged
techknowlogick merged 10 commits into
go-gitea:masterfrom
TTWNO:config_default_push_private_public
Sep 27, 2020
Merged

Add config option to make create-on-push repositories public by default#12936
techknowlogick merged 10 commits into
go-gitea:masterfrom
TTWNO:config_default_push_private_public

Conversation

@TTWNO
Copy link
Copy Markdown
Contributor

@TTWNO TTWNO commented Sep 24, 2020

This is a super simple config addition to allow public-by-default push-to-create repositories.

The option DEFAULT_PUSH_CREATE_PRIVATE is true by default, but can be overridden in the config file.
If there is anything I missed, let me know.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #12936 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12936   +/-   ##
=======================================
  Coverage   42.84%   42.85%           
=======================================
  Files         662      662           
  Lines       73002    73002           
=======================================
+ Hits        31279    31282    +3     
+ Misses      36652    36650    -2     
+ Partials     5071     5070    -1     
Impacted Files Coverage Δ
modules/setting/repository.go 56.36% <ø> (ø)
services/repository/repository.go 48.88% <100.00%> (ø)
modules/avatar/avatar.go 50.00% <0.00%> (-4.77%) ⬇️
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82179a6...bbe9475. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 24, 2020
Signed-off-by: a1012112796 <1012112796@qq.com>
@a1012112796
Copy link
Copy Markdown
Member

@TTWNO @lunny I have added chinese translation in TTWNO#1, Please have a look, Thanks

@techknowlogick techknowlogick added this to the 1.14.0 milestone Sep 24, 2020
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Sep 24, 2020
Copy link
Copy Markdown
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2020
Copy link
Copy Markdown
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 27, 2020
@techknowlogick techknowlogick modified the milestones: 1.14.0, 1.13.0 Sep 27, 2020
@techknowlogick techknowlogick merged commit c85c9d4 into go-gitea:master Sep 27, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants