Completely quote AppPath and CustomConf paths#12955
Merged
techknowlogick merged 5 commits intoSep 29, 2020
Merged
Conversation
Properly handle spaces in AppPath and CustomConf within hooks and authorized_keys. Unfortunately here we don't seem to be able to get away with using go-shellquote as it appears that Windows doesn't play too well with singlequote quoting - therefore we will avoid singlequote quoting unless we absolutely cannot get away without it, e.g. \n or !. Fix go-gitea#10813 Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-10813-spaces-in-AppPath
branch
from
955e80d to
8ef1190
Compare
Member
|
Please fix also test |
GiteaBot
added
the
lgtm/need 2
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #12955 +/- ##
==========================================
+ Coverage 42.63% 42.64% +0.01%
==========================================
Files 669 670 +1
Lines 73495 73522 +27
==========================================
+ Hits 31331 31351 +20
+ Misses 37094 37091 -3
- Partials 5070 5080 +10
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Sep 28, 2020
GiteaBot
added
lgtm/need 1
6543
reviewed
Sep 28, 2020
6543
approved these changes
Sep 28, 2020
GiteaBot
added
lgtm/done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handle spaces in AppPath and CustomConf within hooks and
authorized_keys. Unfortunately here we don't seem to be able to get away
with using go-shellquote as it appears that Windows doesn't play too
well with singlequote quoting - therefore we will avoid singlequote
quoting unless we absolutely cannot get away without it, e.g. \n or !.
Fix #10813
Signed-off-by: Andrew Thornton art27@cantab.net