Only set the user password if the password field would have been shown#12980
Merged
zeripath merged 2 commits intoSep 29, 2020
Conversation
POSTing to /admin/users/:id should only set the password if the the user IsLocal or IsOauth2 Fix go-gitea#12952 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Sep 29, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Sep 29, 2020
GiteaBot
added
lgtm/done
…in-page-if-it-was-shown
Codecov Report
@@ Coverage Diff @@
## master #12980 +/- ##
==========================================
+ Coverage 42.54% 42.58% +0.03%
==========================================
Files 670 671 +1
Lines 73522 73627 +105
==========================================
+ Hits 31281 31353 +72
- Misses 37175 37187 +12
- Partials 5066 5087 +21
Continue to review full report at Codecov.
|
Member
|
🚀 |
zeripath
deleted the
fix-12952-only-check-password-field-on-admin-page-if-it-was-shown
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POSTing to
/admin/users/:idshould only set/check the password if the the userIsLocal()orIsOauth2()Fix #12952
Signed-off-by: Andrew Thornton art27@cantab.net