Skip to content

Prevent empty div when editing comment (#12404)#12992

Closed
6543 wants to merge 1 commit into
go-gitea:release/v1.12from
6543-forks:backport_fix-10220-no-empty-attachments-div_12404
Closed

Prevent empty div when editing comment (#12404)#12992
6543 wants to merge 1 commit into
go-gitea:release/v1.12from
6543-forks:backport_fix-10220-no-empty-attachments-div_12404

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Sep 30, 2020

Backport #12404
close #12895

* Prevent empty div when editing comment

The template for attachments needs to remove whitespace and return empty when there are no attachments.

Fix go-gitea#10220
@6543 6543 added the type/bug label Sep 30, 2020
@6543 6543 added this to the 1.12.5 milestone Sep 30, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Sep 30, 2020

was not first .. -> #12991

@6543 6543 closed this Sep 30, 2020
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 30, 2020
@6543 6543 deleted the backport_fix-10220-no-empty-attachments-div_12404 branch September 30, 2020 23:10
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants