fix: media links in org files not liked to media files#12997
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12997 +/- ##
=======================================
Coverage 42.58% 42.59%
=======================================
Files 671 671
Lines 73625 73632 +7
=======================================
+ Hits 31356 31365 +9
+ Misses 37193 37184 -9
- Partials 5076 5083 +7
Continue to review full report at Codecov.
|
zeripath
reviewed
Oct 1, 2020
Contributor
|
Thanks for the PR - this looks like it would solve the problem - however, as a r is an io.Writer we should just get fmt.Fprintf to write to it directly instead of using the r.WriteString method. |
as suggested by code review Co-authored-by: zeripath <art27@cantab.net>
zeripath
approved these changes
Oct 1, 2020
mrsdizzie
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Org files, links to images and videos will be linked to "/media/" path, similar to
gitea/modules/markup/markdown/goldmark.go
Lines 87 to 93 in 6a1a633
Fixes #12831