[#13004] Add Timestamp to Tag list API#13026
Merged
lunny merged 5 commits intoOct 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13026 +/- ##
==========================================
- Coverage 42.55% 42.54% -0.01%
==========================================
Files 672 672
Lines 73715 73716 +1
==========================================
- Hits 31367 31361 -6
- Misses 37264 37272 +8
+ Partials 5084 5083 -1
Continue to review full report at Codecov.
|
Member
|
Pleace add a test :) |
Contributor
Author
|
@6543 I've added unit tests for the |
a1012112796
approved these changes
Oct 4, 2020
lafriks
approved these changes
Oct 4, 2020
6543
reviewed
Oct 4, 2020
Member
|
@LucasQueiroz just |
Contributor
Author
Whoops my bad! |
6543
approved these changes
Oct 5, 2020
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request aims to solve the problem described on #13004, adding a timestamp to the tag list API.
As this is my first time writing Go code, please let me know if there's anything that could be improved.
I did not find any unit tests for the changed object.
Results
When running the API locally, the swagger docs result in this:
And the API returns the following information: