Fix Issue & Pull Request comment headers on mobile#13039
Merged
techknowlogick merged 1 commit intoOct 5, 2020
Conversation
Signed-off-by: kolaente <k@knt.li>
Codecov Report
@@ Coverage Diff @@
## master #13039 +/- ##
==========================================
- Coverage 42.62% 42.60% -0.02%
==========================================
Files 672 672
Lines 73785 73785
==========================================
- Hits 31448 31439 -9
- Misses 37247 37253 +6
- Partials 5090 5093 +3
Continue to review full report at Codecov.
|
zeripath
approved these changes
Oct 5, 2020
6543
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Issue and PR comment headers on mobile. The changes I made also work on desktop which is why I didn't use media queries. This has the nice side effect to make the header look good in edge cases where user's have really long names which wouldn't fit the header even on desktop.
We could also discuss hiding the avatar completely and let the comments take the full width on mobile (like github does) but that would be a separate change.
Before:
After: