Improve error feedback for duplicate deploy keys

[chrisshyi]

Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template to inform the user that a key with the intended title already exists. Resolves #13110

[zeripath]

Hi thanks for the PR!

Could you add handling to routers/api/v1/repo/key.go:172-183:func HandleAddKeyError(ctx *context.APIContext, err error) { too?

[6543]

👍

[zeripath]

also I suspect that we need to "handle" more of the "expected" errors in models/user.go:1751-1772:func addLdapSSHPublicKeys(usr *User, s *LoginSource, sshPublicKeys []string) bool { but that could be a different PR. (Mostly switching them to log.Trace(...) instead of log.Error(...)

[6543]

I'm fine with as is and yes it's true there could be handled more of that stuff witch is currently not

already solve the issue in this state ...
@chrisshyi would be niche if you can fix more :)

[chrisshyi]

Could you add handling to routers/api/v1/repo/key.go:172-183:func HandleAddKeyError(ctx *context.APIContext, err error) { too?

I just did!

[codecov-io]

Codecov Report

Merging #13112 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #13112   +/-   ##
=======================================
  Coverage   42.52%   42.52%           
=======================================
  Files         673      673           
  Lines       74111    74116    +5     
=======================================
+ Hits        31514    31517    +3     
  Misses      37478    37478           
- Partials     5119     5121    +2     

Impacted Files	Coverage Δ
models/error.go	34.34% <0.00%> (-0.51%)	⬇️
routers/api/v1/repo/key.go	16.85% <0.00%> (-0.39%)	⬇️
routers/repo/setting.go	14.62% <0.00%> (-0.08%)	⬇️
modules/indexer/stats/db.go	43.47% <0.00%> (-17.40%)	⬇️
modules/indexer/stats/queue.go	64.70% <0.00%> (-11.77%)	⬇️
modules/git/utils.go	73.77% <0.00%> (-3.28%)	⬇️
modules/git/repo.go	46.19% <0.00%> (-1.53%)	⬇️
modules/queue/workerpool.go	58.77% <0.00%> (-1.23%)	⬇️
services/pull/pull.go	40.78% <0.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e4f663...f46c127. Read the comment docs.

[6543]

🚀

[chrisshyi]

also I suspect that we need to "handle" more of the "expected" errors in models/user.go:1751-1772:func addLdapSSHPublicKeys(usr *User, s *LoginSource, sshPublicKeys []string) bool {

I'll see if I can tackle that in another PR. Thank you both for the speedy review!