When handling errors in storageHandler check underlying error#13178
Merged
techknowlogick merged 2 commits intoOct 18, 2020
Conversation
Unfortunately there was a mistake in go-gitea#13164 which fails to handle os.PathError wrapping an os.ErrNotExist Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
approved these changes
Oct 17, 2020
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Oct 18, 2020
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## master #13178 +/- ##
==========================================
+ Coverage 42.01% 42.02% +0.01%
==========================================
Files 683 683
Lines 75215 75215
==========================================
+ Hits 31602 31611 +9
+ Misses 38448 38439 -9
Partials 5165 5165
Continue to review full report at Codecov.
|
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Oct 18, 2020
…ea#13178) Unfortunately there was a mistake in go-gitea#13164 which fails to handle os.PathError wrapping an os.ErrNotExist Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Contributor
Author
|
Backport included in #13193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately there was a mistake in #13164 which fails to handle
os.PathError wrapping an os.ErrNotExist
Signed-off-by: Andrew Thornton art27@cantab.net