Storage configuration support [storage]#13314
Merged
Merged
Conversation
zeripath
approved these changes
Oct 26, 2020
techknowlogick
approved these changes
Oct 26, 2020
f86ca3a to
8c5bec1
Compare
Member
|
|
Member
Author
|
The file tested in LFS is 10 bytes, and the request is range=11-, so the correct response of HTTP standard is to return an error or just ignore that? The behaviour between |
Member
|
It should be fixed for file and minio to behave the same and handle that |
Member
Author
|
@lafriks Yes, so which one should choose? Return io.EOF or just ignore them? |
95bdb4f to
d060e31
Compare
Member
Author
|
OK. I think https://developer.mozilla.org/en-US/docs/Web/HTTP/Range_requests explained we should return 416. |
a930f33 to
886fbfb
Compare
Member
|
🚀 |
Member
|
@lunny please send backport :) |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Nov 1, 2020
* Fix minio bug * Add tests for storage configuration * Change the Seek flag to keep compitable minio? * Fix test when first-byte-pos of all ranges is greater than the resource length Co-authored-by: techknowlogick <techknowlogick@gitea.io>
lunny
added a commit
that referenced
this pull request
Nov 1, 2020
* Fix minio bug * Add tests for storage configuration * Change the Seek flag to keep compitable minio? * Fix test when first-byte-pos of all ranges is greater than the resource length Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusted the override sequence,
[storage]<-[storage.minio]<-[storage.attachments]. Right section will override left.In fact,
[storage]is expected because it's more easier to remember.This will also enable storage tests with minio when mysql integration tests.
This also changed the behaviour of lfs serve when given a range start value out of bounds, now it will return 416, but not ignore that like before.