Add email validity check by chrisshyi · Pull Request #13475 · go-gitea/gitea

chrisshyi · 2020-11-09T04:41:07Z

Added email validity checking for the following actions:

User update
User email addition
- Through the web interface
- Through the /user/emails endpoint
User creation:
- Through the admin interface
- Through the /admin/users endpoint

Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists.

Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails

lafriks

Wrong button, see comment above

codecov-io · 2020-11-11T02:50:12Z

Codecov Report

Merging #13475 (f0df7e6) into master (7d2700c) will increase coverage by 0.06%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #13475      +/-   ##
==========================================
+ Coverage   42.16%   42.22%   +0.06%     
==========================================
  Files         696      696              
  Lines       76480    76518      +38     
==========================================
+ Hits        32247    32311      +64     
+ Misses      38939    38911      -28     
- Partials     5294     5296       +2

Impacted Files	Coverage Δ
routers/api/v1/user/email.go	`0.00% <0.00%> (ø)`
routers/user/setting/account.go	`25.51% <0.00%> (-0.54%)`	⬇️
models/user_mail.go	`50.38% <33.33%> (-0.41%)`	⬇️
routers/admin/users.go	`27.77% <50.00%> (+2.06%)`	⬆️
routers/api/v1/admin/user.go	`30.57% <50.00%> (+14.54%)`	⬆️
routers/user/auth.go	`12.19% <50.00%> (+0.53%)`	⬆️
models/user.go	`54.36% <75.00%> (+0.12%)`	⬆️
models/error.go	`36.75% <100.00%> (+1.52%)`	⬆️
modules/queue/workerpool.go	`57.95% <0.00%> (-0.82%)`	⬇️
models/gpg_key.go	`53.33% <0.00%> (-0.58%)`	⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2700c...f0df7e6. Read the comment docs.

techknowlogick

Thanks :)

techknowlogick · 2020-11-14T03:58:19Z

@lunny please review

* Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. * API returns 422 error when key with name exists * Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails * Add further tests * Add signup email tests * Add email validity check for linking existing account * Address PR comments * Remove unneeded DB session * Move email check to updateUser Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

6543 · 2020-11-21T17:55:17Z

-> #13666

* Add email validity check (#13475) * Improve error feedback for duplicate deploy keys Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists. * API returns 422 error when key with name exists * Add email validity checking Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails * Add further tests * Add signup email tests * Add email validity check for linking existing account * Address PR comments * Remove unneeded DB session * Move email check to updateUser Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io> * skip email validation on empty string (#13627) - move validation into its own function - use a session for UpdateUserSetting * rm TODO for backport Co-authored-by: Chris Shyi <chrisshyi13@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Chris Shyi and others added 10 commits October 12, 2020 17:10

Improve error feedback for duplicate deploy keys

df0bcef

Instead of a generic HTTP 500 error page, a flash message is rendered with the deploy key page template so inform the user that a key with the intended title already exists.

API returns 422 error when key with name exists

c4341c2

Merge branch 'master' into master

f46c127

Merge remote-tracking branch 'upstream/master'

e8745e3

Add email validity checking

1a539ef

Add email validity checking for the following routes: [Web interface] 1. User registration 2. User creation by admin 3. Adding an email through user settings [API] 1. POST /admin/users 2. PATCH /admin/users/:username 3. POST /user/emails

Merge remote-tracking branch 'upstream/master'

354f957

Merge remote-tracking branch 'upstream/master'

2d2b60d

Add further tests

b400388

Add signup email tests

bfdb76c

Add email validity check for linking existing account

fb476e2

lunny requested changes Nov 9, 2020

View reviewed changes

Comment thread models/user.go Outdated

Comment thread options/locale/locale_zh-TW.ini Outdated

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 9, 2020

lunny added the type/enhancement An improvement of existing functionality label Nov 9, 2020

Address PR comments

3684d64

chrisshyi requested a review from lunny November 9, 2020 06:05

chrisshyi changed the title ~~Adding email validity check~~ Add email validity check Nov 9, 2020

Merge branch 'master' into master

751c717

lafriks approved these changes Nov 9, 2020

View reviewed changes

Comment thread models/user.go Outdated

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 9, 2020

lafriks requested changes Nov 9, 2020

View reviewed changes

chrisshyi added 2 commits November 9, 2020 15:34

Remove unneeded DB session

19d3003

Merge branch 'master' of github.com:chrisshyi/gitea

1df58a5

chrisshyi requested a review from lafriks November 9, 2020 07:40

lafriks added this to the 1.14.0 milestone Nov 9, 2020

lafriks approved these changes Nov 9, 2020

View reviewed changes

techknowlogick requested changes Nov 10, 2020

View reviewed changes

Comment thread models/user.go

Move email check to updateUser

24ecaba

6543 approved these changes Nov 11, 2020

View reviewed changes

GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 11, 2020

GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 11, 2020

techknowlogick approved these changes Nov 11, 2020

View reviewed changes

lunny approved these changes Nov 14, 2020

View reviewed changes

lunny and others added 3 commits November 14, 2020 21:41

Merge branch 'master' into master

9465ec3

Merge branch 'master' into master

e9d284f

Merge branch 'master' into master

f0df7e6

techknowlogick merged commit d025d84 into go-gitea:master Nov 14, 2020

This was referenced Nov 18, 2020

500 on org private to public, public to private and public to limited #13587

Closed

skip email validation on empty string #13627

Merged

6543 added the backport/v1.13 label Nov 21, 2020

6543 mentioned this pull request Nov 21, 2020

Validate email before inserting/updating (#13475) #13666

Merged

6543 added the backport/done All backports for this PR have been created label Nov 21, 2020

go-gitea locked and limited conversation to collaborators Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add email validity check#13475

Add email validity check#13475
techknowlogick merged 18 commits into
go-gitea:masterfrom
chrisshyi:master

chrisshyi commented Nov 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lafriks left a comment

Uh oh!

Uh oh!

codecov-io commented Nov 11, 2020 •

edited

Loading

Uh oh!

techknowlogick left a comment

Uh oh!

techknowlogick commented Nov 14, 2020

Uh oh!

6543 commented Nov 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

chrisshyi commented Nov 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lafriks left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-io commented Nov 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

techknowlogick left a comment

Choose a reason for hiding this comment

Uh oh!

techknowlogick commented Nov 14, 2020

Uh oh!

6543 commented Nov 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codecov-io commented Nov 11, 2020 •

edited

Loading