Fix panic bug in handling multiple references in commit (#13486)#13487
Merged
techknowlogick merged 2 commits intoNov 10, 2020
Conversation
The issue lay in determining the position of matches on a second run round a commit message in FindAllIssueReferences. Fix go-gitea#13483 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
added
type/bug
issue/critical
zeripath
approved these changes
Nov 9, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Nov 9, 2020
GiteaBot
added
lgtm/done
Contributor
Member
Author
|
@zeripath why not ... I dont know how many backports we will make, but each time we do ... your patch could be usefull |
Contributor
|
Feel free to make a backport of it |
Member
Author
|
🚀 |
6543
deleted the
backport_zeripath_fix-13483-error-in-reference-munching
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue lay in determining the position of matches on a second run round
a commit message in FindAllIssueReferences.
Fix #13483
Backport #13486