Disallow urlencoded new lines in git protocol paths if there is a port (#13521)#13525
Merged
Merged
Conversation
go-gitea#13521) Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
approved these changes
Nov 11, 2020
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Nov 11, 2020
GiteaBot
added
lgtm/done
lafriks
added
topic/security
|
LGTM |
|
CVE-2020-28991 was assigned to this issue. |
The impact is that this vulnerability can cause partial SSRF. I'm keeping it an additional reference in here as an original reporter. (This comment may change in the future) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #13521