Skip to content

missing quotes in default value slice#13550

Merged
techknowlogick merged 3 commits into
go-gitea:masterfrom
patcito:patch-1
Nov 14, 2020
Merged

missing quotes in default value slice#13550
techknowlogick merged 3 commits into
go-gitea:masterfrom
patcito:patch-1

Conversation

@patcito
Copy link
Copy Markdown
Contributor

@patcito patcito commented Nov 13, 2020

seems like a quote is missing here

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 13, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 14, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 14, 2020

Codecov Report

Merging #13550 (d678086) into master (e16b0e5) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13550      +/-   ##
==========================================
+ Coverage   42.16%   42.17%   +0.01%     
==========================================
  Files         696      696              
  Lines       76438    76438              
==========================================
+ Hits        32228    32237       +9     
+ Misses      38925    38916       -9     
  Partials     5285     5285
Impacted Files Coverage Δ
modules/setting/repository.go 56.36% <ø> (ø)
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 43.47% <0.00%> (-8.70%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
models/error.go 35.72% <0.00%> (ø)
services/pull/pull.go 41.27% <0.00%> (+0.49%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
services/pull/check.go 51.09% <0.00%> (+2.18%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16b0e5...bb07816. Read the comment docs.

@techknowlogick techknowlogick merged commit a2efcb6 into go-gitea:master Nov 14, 2020
techknowlogick added a commit to techknowlogick/gitea that referenced this pull request Nov 14, 2020
@patcito @lunny @techknowlogick
missing quotes in default value slice (go-gitea#13550)
b53017a 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@techknowlogick techknowlogick mentioned this pull request Nov 14, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Nov 14, 2020
@techknowlogick
Copy link
Copy Markdown
Member

techknowlogick commented Nov 14, 2020

I've backported this in PR #13557

lafriks pushed a commit that referenced this pull request Nov 14, 2020
@techknowlogick @patcito @lunny
missing quotes in default value slice (#13550) (#13557)
9a8e02c 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: Patrick Aljord <patcito@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

6 participants

@patcito @codecov-io @techknowlogick @lunny @lafriks @GiteaBot