Skip to content

[API] Only Return Json (#13511)#13564

Merged
zeripath merged 1 commit into
go-gitea:release/v1.12from
6543-forks:backport_api-only-json_13511
Nov 15, 2020
Merged

[API] Only Return Json (#13511)#13564
zeripath merged 1 commit into
go-gitea:release/v1.12from
6543-forks:backport_api-only-json_13511

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Nov 14, 2020

Backport #13511

* Let Branch and Raw Endpoint return json error if not found

* Revert "RM RepoRefByTypeForAPI and move needed parts into GetRawFile directly"

This reverts commit d826d08577b23765cb3c257e7a861191d1aa9a04.

* more similar to RepoRefByType

* dedub-code

* API should just speak JSON

* nice name

Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Nov 14, 2020
@6543 6543 added this to the 1.12.6 milestone Nov 14, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Nov 14, 2020

@bot label?

@6543 6543 added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 14, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2020
@6543
Copy link
Copy Markdown
Member Author

6543 commented Nov 15, 2020

🚀

@zeripath zeripath merged commit dc9f5a7 into go-gitea:release/v1.12 Nov 15, 2020
@6543 6543 deleted the backport_api-only-json_13511 branch November 15, 2020 20:52
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants