Add Allow-/Block-List for Migrate & Mirrors by 6543 · Pull Request #13610 · go-gitea/gitea

6543 · 2020-11-17T22:41:00Z

This PR will add two options blocklist and allowlist for migrating repositories from external URLs.

When you set allowlist then blocklist will be ignored and all users on this gitea instance could only migrate repositories from the domains on allowlist.

When allowlist is empty and you have domains on blocklist, all users on this gitea instance could migrate repositories any domain except the domains on blocklist.

original pull: #8040
close #4462

TODOs:

add default blocklist for private networks & localhost
test manually to ensure it works

codecov-io · 2020-11-17T23:53:22Z

Codecov Report

Merging #13610 (870ca5b) into master (1e5247d) will increase coverage by 0.02%.
The diff coverage is 63.01%.

@@            Coverage Diff             @@
##           master   #13610      +/-   ##
==========================================
+ Coverage   42.21%   42.24%   +0.02%     
==========================================
  Files         697      698       +1     
  Lines       76845    76917      +72     
==========================================
+ Hits        32439    32490      +51     
- Misses      39054    39063       +9     
- Partials     5352     5364      +12

Impacted Files	Coverage Δ
routers/init.go	`51.21% <0.00%> (-0.85%)`	⬇️
modules/matchlist/matchlist.go	`37.50% <37.50%> (ø)`
modules/setting/migrations.go	`63.63% <42.85%> (-36.37%)`	⬇️
models/error.go	`38.66% <66.66%> (+1.90%)`	⬆️
modules/migrations/migrate.go	`31.52% <78.37%> (+9.97%)`	⬆️
routers/api/v1/repo/migrate.go	`46.71% <100.00%> (+3.75%)`	⬆️
services/pull/check.go	`48.90% <0.00%> (-3.65%)`	⬇️
services/pull/temp_repo.go	`26.59% <0.00%> (-3.20%)`	⬇️
modules/process/manager.go	`72.50% <0.00%> (-2.50%)`	⬇️
services/pull/patch.go	`53.97% <0.00%> (-1.71%)`	⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5247d...870ca5b. Read the comment docs.

silverwind · 2020-11-28T14:32:35Z

Still need to update app.example.ini with new names.

zeripath · 2020-11-28T14:37:56Z

Still need to update app.example.ini with new names.

Is that now fixed?

silverwind · 2020-11-28T14:38:54Z

Yes those look fine now.

6543 · 2020-11-29T00:00:45Z

🚀

* add black list and white list support for migrating repositories * specify log message * use blocklist/allowlist * allways use lowercase to match url * Apply allow/block * Settings: use existing "migrations" section * convert domains lower case * dont store unused value * Block private addresses for migration by default * use proposed-upstream func to detect private IP addr * add own error for blocked migration, add tests, imprufe api * fix test * fix-if-localhost-is-ipv4 * rename error & error message * rename setting options * Apply suggestions from code review Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

* add black list and white list support for migrating repositories * specify log message * use blocklist/allowlist * allways use lowercase to match url * Apply allow/block * Settings: use existing "migrations" section * convert domains lower case * dont store unused value * Block private addresses for migration by default * use proposed-upstream func to detect private IP addr * add own error for blocked migration, add tests, imprufe api * fix test * fix-if-localhost-is-ipv4 * rename error & error message * rename setting options * Apply suggestions from code review Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>

lunny and others added 6 commits September 11, 2019 22:51

add black list and white list support for migrating repositories

7a083b9

fix fmt

3f2b34b

fix lint

ad5a226

fix vendor

7280964

fix modules.txt

cdff51c

Merge branch 'master' into allow-block_list_migrate-mirror_8040

ab362e5

6543 added this to the 1.14.0 milestone Nov 17, 2020

6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review labels Nov 17, 2020

6543 mentioned this pull request Nov 17, 2020

Add black list and white list support for migrating repositories #8040

Closed

6543 added 4 commits November 17, 2020 23:50

clean diff

ec4dbc8

specify log message

770dab6

use blocklist/allowlist

05e45bf

allways use lowercase to match url

a078736

6543 commented Nov 17, 2020

View reviewed changes

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 17, 2020

Apply allow/block

dec70f1

6543 commented Nov 17, 2020

View reviewed changes

Comment thread modules/setting/migrate.go Outdated

Merge branch 'master' into allow-block_list_migrate-mirror_8040

d2c1619

6543 mentioned this pull request Nov 18, 2020

[Feature] block-/allow-list for emails #13628

Closed

6543 added 2 commits November 21, 2020 18:42

Settings: use existing "migrations" section

840fc85

Merge branch 'master' into allow-block_list_migrate-mirror_8040

af32a09

6543 force-pushed the allow-block_list_migrate-mirror_8040 branch from da14604 to af32a09 Compare November 21, 2020 17:54

6543 added 4 commits November 23, 2020 23:29

convert domains lower case

9f5e0de

Merge branch 'master' into allow-block_list_migrate-mirror_8040

3ede511

dont store unused value

37f45f4

Block private addresses for migration by default

e0934b8

6543 commented Nov 23, 2020

View reviewed changes

Comment thread custom/conf/app.example.ini Outdated

fix lint

43982b4

6543 added 3 commits November 28, 2020 01:07

Merge branch 'master' into allow-block_list_migrate-mirror_8040

aa8ec6f

rename setting options

bb5ce58

Merge branch 'master' into allow-block_list_migrate-mirror_8040

9815e9d

zeripath approved these changes Nov 28, 2020

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2020

zeripath reviewed Nov 28, 2020

View reviewed changes

Comment thread custom/conf/app.example.ini Outdated

Comment thread custom/conf/app.example.ini Outdated

Comment thread custom/conf/app.example.ini Outdated

Comment thread custom/conf/app.example.ini Outdated

Apply suggestions from code review

e13cd15

Merge branch 'master' into allow-block_list_migrate-mirror_8040

6602023

lunny approved these changes Nov 28, 2020

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2020

lunny and others added 4 commits November 28, 2020 23:56

Merge branch 'master' into allow-block_list_migrate-mirror_8040

870ca5b

Merge branch 'master' into allow-block_list_migrate-mirror_8040

e091333

Merge branch 'master' into allow-block_list_migrate-mirror_8040

7850e5e

Merge branch 'master' into allow-block_list_migrate-mirror_8040

3c67197

techknowlogick merged commit b2435af into go-gitea:master Nov 29, 2020

6543 deleted the allow-block_list_migrate-mirror_8040 branch November 29, 2020 00:45

6543 mentioned this pull request Dec 1, 2020

Add Allow-/Block-List for Migrate & Mirrors (#13610) #13776

Merged

6543 added topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! backport/v1.13 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 1, 2020

6543 added the backport/done All backports for this PR have been created label Dec 1, 2020

go-gitea locked and limited conversation to collaborators Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Allow-/Block-List for Migrate & Mirrors#13610

Add Allow-/Block-List for Migrate & Mirrors#13610
techknowlogick merged 38 commits into
go-gitea:masterfrom
6543-forks:allow-block_list_migrate-mirror_8040

6543 commented Nov 17, 2020 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Nov 17, 2020 •

edited

Loading

Uh oh!

Uh oh!

silverwind commented Nov 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeripath commented Nov 28, 2020

Uh oh!

silverwind commented Nov 28, 2020

Uh oh!

6543 commented Nov 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

6543 commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-io commented Nov 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

silverwind commented Nov 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zeripath commented Nov 28, 2020

Uh oh!

silverwind commented Nov 28, 2020

Uh oh!

6543 commented Nov 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

6543 commented Nov 17, 2020 •

edited

Loading

codecov-io commented Nov 17, 2020 •

edited

Loading