Skip to content

Consolidate clone button templates#14023

Merged
techknowlogick merged 2 commits into
go-gitea:masterfrom
silverwind:remember-ssh
Dec 28, 2020
Merged

Consolidate clone button templates#14023
techknowlogick merged 2 commits into
go-gitea:masterfrom
silverwind:remember-ssh

Conversation

@silverwind
Copy link
Copy Markdown
Member

@silverwind silverwind commented Dec 16, 2020

The four clone button templates are pretty much identical except the one in a non-empty repo had a few features which the others lacked (ExposeAnonSSH check on empty repo and the JS which was previously working on all of them but regressed in #13626).

Consolidate them in a single shared template which also makes the JS that remembers protocol work on them all again.

The four clone button templates are pretty much identical except the one
in a non-empty repo had a few features which the others lacked.

Consolidate them in a single shared template which also makes the JS
that remembers protocol work on them all.
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 16, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 16, 2020
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 16, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 28, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Dec 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 28, 2020
@techknowlogick
Copy link
Copy Markdown
Member

🚀

@techknowlogick techknowlogick merged commit 9a4050f into go-gitea:master Dec 28, 2020
@silverwind silverwind deleted the remember-ssh branch December 29, 2020 09:30
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants