Skip to content

Fix integrations test error with space in CURDIR path #14056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2020
Merged

Fix integrations test error with space in CURDIR path #14056

merged 2 commits into from
Dec 19, 2020

Conversation

kdumontnu
Copy link
Contributor

Closes #14055

Put all instances of ${CURDIR} in makefile within quotes to allow running integration tests in a directory with space in the path.

@silverwind
Copy link
Member

Thanks. Can you make it "$(CURDIR)". Those braces behave exactly the same but we generally use round ones throughout the Makefile so these curly ones just seem inconsistent to me.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 18, 2020
@silverwind silverwind added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Dec 18, 2020
@kdumontnu kdumontnu force-pushed the kd/fix_path_split_integration_test branch from a5515b6 to 1c84b65 Compare December 18, 2020 22:33
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 18, 2020
zeripath
zeripath approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to make setting GITEA_ROOT unnecessary.

However this does what it says on the tin

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 18, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 19, 2020
@techknowlogick
Copy link
Member

@kdumontnu you're on a roll, thanks for another PR :) Could you press the "update branch" button on this page (right above where comment box is)? When contributing from a fork from an org Github doesn't provide permissions to maintainers to update that branch on our side.

@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 4ef7512 into go-gitea:master Dec 19, 2020
lunny added a commit that referenced this pull request Dec 19, 2020
@lunny
Revert "put ${CURDIR} in quotes to prevent make from splitting paths …
5912c31 
…with spaces into separate strings (#14056)"

This reverts commit 4ef7512.
@kdumontnu kdumontnu deleted the kd/fix_path_split_integration_test branch December 31, 2020 06:19
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Integration tests fail with space in path
5 participants
@kdumontnu @silverwind @techknowlogick @zeripath @GiteaBot