Conversation
8ecdfb9 to
07ce068
Compare
426ec54 to
673b3d4
Compare
253c02a to
e72c4c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #14293 +/- ##
==========================================
+ Coverage 41.74% 42.05% +0.30%
==========================================
Files 751 758 +7
Lines 80193 81014 +821
==========================================
+ Hits 33479 34068 +589
- Misses 41183 41391 +208
- Partials 5531 5555 +24
Continue to review full report at Codecov.
|
6543
reviewed
Jan 24, 2021
6543
reviewed
Jan 24, 2021
a1012112796
reviewed
Jan 25, 2021
a1012112796
reviewed
Jan 25, 2021
…the middleware could be recover
Member
Author
|
@6543 @a1012112796 All done. |
6543
approved these changes
Jan 25, 2021
Member
|
I think we should refactor some things and have a second look at all the context things - but this pull is big enough ... and works fine :) |
lafriks
approved these changes
Jan 26, 2021
Member
|
. |
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293) [skip ci] Updated translations via Crowdin Fix incorrect key name so registerManualConfirm setting works as expected. (go-gitea#14455)
a1012112796
added a commit
to a1012112796/gitea
that referenced
this pull request
Jan 27, 2021
* master: [skip ci] Updated translations via Crowdin Fix bug because of duplicated join (go-gitea#14454) Cron job to cleanup hook_task table (go-gitea#13080) Fix panic 500 page rendering (go-gitea#14474) [skip ci] Updated translations via Crowdin Move macaron to chi (go-gitea#14293)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use chi instead of the forked macaron. Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR.
context.ResponseWriterinterface with an implementationcontext.Response.Routeto wrap chi so that the router usage is similar as before.web,api,internalandinstallso that the codes will be more clear and no magic .nodbsupport since it will not be maintained. BREAKcode.gitea.io/gitea/modules/translationcode.gitea.io/gitea/modules/authtocode.gitea.io/gitea/modules/formsto avoid dependency cycle.web.GetForm(ctx)in the route function but not as a function parameter on routes definition./api/v1/swaggernow will be redirect to/api/swaggerbut not render directly so thatAPIContextwill not create a html render.Notices:
TestUserHeatmapmaybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI.UPDATE: 2021.01.27
HOST,PORTandMACARON_ENVhas been removed. BREAK