Skip to content

Set default language to first element of LANGS #14846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions custom/conf/app.example.ini
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,7 @@ JWT_SECRET =
MAX_TOKEN_LENGTH = 32767

[i18n]
; List of locales shown in language selector. First element is default language.
LANGS = en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,uk-UA,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR
NAMES = English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,Українська,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어

Expand Down
2 changes: 1 addition & 1 deletion docs/content/doc/advanced/config-cheat-sheet.en-us.md
Original file line number Diff line number Diff line change
Expand Up @@ -813,7 +813,7 @@ NB: You must have `DISABLE_ROUTER_LOG` set to `false` for this option to take ef

## i18n (`i18n`)

- `LANGS`: **en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR**: List of locales shown in language selector
- `LANGS`: **en-US,zh-CN,zh-HK,zh-TW,de-DE,fr-FR,nl-NL,lv-LV,ru-RU,ja-JP,es-ES,pt-BR,pt-PT,pl-PL,bg-BG,it-IT,fi-FI,tr-TR,cs-CZ,sr-SP,sv-SE,ko-KR**: List of locales shown in language selector. First element is default language.
- `NAMES`: **English,简体中文,繁體中文(香港),繁體中文(台灣),Deutsch,français,Nederlands,latviešu,русский,日本語,español,português do Brasil,Português de Portugal,polski,български,italiano,suomi,Türkçe,čeština,српски,svenska,한국어**: Visible names corresponding to the locales

## U2F (`U2F`)
Expand Down
12 changes: 9 additions & 3 deletions modules/translation/translation.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ type LangType struct {
}

var (
matcher language.Matcher
allLangs []LangType
matcher language.Matcher
allLangs []LangType
defaultLang string
)

// AllLangs returns all supported langauages
Expand Down Expand Up @@ -68,7 +69,9 @@ func InitLocales() {
}
}
}
i18n.SetDefaultLang("en-US")

defaultLang = setting.Langs[0]
i18n.SetDefaultLang(setting.Langs[0])

allLangs = make([]LangType, 0, i18n.Count()-1)
langs := i18n.ListLangs()
Expand All @@ -90,6 +93,9 @@ type locale struct {

// NewLocale return a locale
func NewLocale(lang string) Locale {
if len(lang) == 0 {
lang = defaultLang
}
return &locale{
Lang: lang,
}
Expand Down