Prevent panic when editing forked repos by API#14960
Merged
Merged
Conversation
When editing forked repos using the API the BaseRepository needs to loaded in order to check its visibility otherwise there will be NPE panic. Fix go-gitea#14956 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Mar 11, 2021
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Mar 11, 2021
GiteaBot
added
lgtm/done
jolheiser
approved these changes
Mar 11, 2021
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Mar 11, 2021
When editing forked repos using the API the BaseRepository needs to loaded in order to check its visibility otherwise there will be NPE panic. Fix go-gitea#14956 Signed-off-by: Andrew Thornton <art27@cantab.net>
Member
|
Backport: #14963 |
lunny
pushed a commit
that referenced
this pull request
Mar 12, 2021
When editing forked repos using the API the BaseRepository needs to loaded in order to check its visibility otherwise there will be NPE panic. Fix #14956 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When editing forked repos using the API the BaseRepository needs to loaded
in order to check its visibility otherwise there will be NPE panic.
Fix #14956
Signed-off-by: Andrew Thornton art27@cantab.net