Make sure sibling images get a link too#14979
Merged
zeripath merged 7 commits intoMar 14, 2021
Merged
Conversation
Due a problem with the ast.Walker in the our transformer in goldmark an image with a sibling image will not be transformed to gain a parent link. This PR fixes this. Fix go-gitea#12925 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
topic/ui
Member
|
Could you add a testcase, I'm struggling to understand what this is for ;) |
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Mar 13, 2021
GiteaBot
added
lgtm/need 1
Signed-off-by: Andrew Thornton <art27@cantab.net>
GiteaBot
added
lgtm/done
Member
|
testcase is missing a |
zeripath
commented
Mar 13, 2021
Contributor
Author
|
weird it worked locally in vscode |
Codecov Report
@@ Coverage Diff @@
## master #14979 +/- ##
=========================================
Coverage ? 42.24%
=========================================
Files ? 774
Lines ? 83008
Branches ? 0
=========================================
Hits ? 35063
Misses ? 42246
Partials ? 5699
Continue to review full report at Codecov.
|
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 14, 2021
Backport go-gitea#14979 Due a problem with the ast.Walker in the our transformer in goldmark an image with a sibling image will not be transformed to gain a parent link. This PR fixes this. Fix go-gitea#12925 Signed-off-by: Andrew Thornton <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due a problem with the ast.Walker in the our transformer in goldmark
an image with a sibling image will not be transformed to gain a parent
link. This PR fixes this.
Fix #12925
Signed-off-by: Andrew Thornton art27@cantab.net