Fix postgres ID sequences broken by recreate-table#15015
Merged
techknowlogick merged 8 commits intoMar 18, 2021
Conversation
Contributor
Author
|
Should be backportable without the migration of course. |
GiteaBot
added
the
lgtm/need 2
6 tasks
Unfortunately there is a subtle problem with recreatetable on postgres which leads to the sequences not being renamed and not being left at 0. Fix go-gitea#14725 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
recreate-table-postgres-sequences
branch
from
eb5759a to
9411c21
Compare
Contributor
Author
|
Grargh looks like we can't rely on I think |
Member
|
Fails with relation "pg_sequences" does not exist |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Contributor
Author
|
Should now be fixed |
lafriks
approved these changes
Mar 17, 2021
GiteaBot
added
lgtm/need 1
6543
approved these changes
Mar 18, 2021
GiteaBot
added
lgtm/done
Member
|
🚀 |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 18, 2021
Backport go-gitea#15015 Unfortunately there is a subtle problem with recreatetable on postgres which leads to the sequences not being renamed and not being left at 0. Fix go-gitea#14725 Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
that referenced
this pull request
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately there is a subtle problem with recreatetable on postgres which
leads to the sequences not being renamed and being left at 0.
Fix #14725
Signed-off-by: Andrew Thornton art27@cantab.net