Create Proper Migration tests#15116
Merged
Merged
Conversation
Contributor
Author
|
TODO:
|
GiteaBot
added
the
lgtm/need 2
zeripath
changed the title
Contributor
Author
|
OK it's wired in.. The structure is a bit of a hack with the current inferior migration tests still being run from integrations/migration-test - these should probably be either moved in to migrations as proper tests or just removed once we have enough tests to be happy that they are no longer needed. |
zeripath
commented
Mar 22, 2021
zeripath
commented
Mar 22, 2021
Contributor
Author
|
Oh that's interesting there's a bug with drop table columns on mssql ... |
6543
approved these changes
Mar 23, 2021
GiteaBot
added
lgtm/need 1
zeripath
force-pushed
the
migration-tests
branch
from
7ef866d to
ea74c42
Compare
Unfortunately our testing regime has so far meant that migrations do not get proper testing. This PR begins the process of creating migration tests for this. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
migration-tests
branch
from
ea74c42 to
dbc396d
Compare
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
kdumontnu
approved these changes
Mar 24, 2021
Contributor
kdumontnu
left a comment
kdumontnu
left a comment
There was a problem hiding this comment.
Thanks for adding these! 💯
Do you think it would be good practice to add a comment block at the top of v176_test.go and v177_test.go to explain at high level what the migrations intend to do? Ex. "create index X", etc.
GiteaBot
added
lgtm/done
Contributor
Author
|
I think such comments would probably be better on the migration functions themselves. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Mar 24, 2021
6543
added
the
release/highlight
lafriks
removed
the
release/highlight
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately our testing regime has so far meant that migrations do not
get proper testing.
This PR begins the process of creating migration tests for this.
Signed-off-by: Andrew Thornton art27@cantab.net