Repo branch page: label size, PR ref, new PR button alignment#15363
Merged
zeripath merged 3 commits intoMay 11, 2021
Conversation
Member
I think the approach of having to add classes to every link is not ideal. A purely JS-based link detection would surely work better without burdening us to add those classes everywhere. Thought, adding it is fine for now. |
silverwind
approved these changes
Apr 10, 2021
Member
|
Could you post a screenshot comparison? |
6543
pushed a commit
that referenced
this pull request
Apr 16, 2021
zeripath
approved these changes
May 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #15363 +/- ##
==========================================
+ Coverage 43.98% 44.02% +0.04%
==========================================
Files 681 681
Lines 82230 82230
==========================================
+ Hits 36168 36202 +34
+ Misses 40143 40123 -20
+ Partials 5919 5905 -14
Continue to review full report at Codecov.
|
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Co-authored-by: zeripath <art27@cantab.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the above tiny bits.
I'll try my best to backport this and #15276 now.