Skip to content

Repo branch page: label size, PR ref, new PR button alignment#15363

Merged
zeripath merged 3 commits into
go-gitea:mainfrom
CL-Jeremy:repo-branch-css-3rd-column-nits
May 11, 2021
Merged

Repo branch page: label size, PR ref, new PR button alignment#15363
zeripath merged 3 commits into
go-gitea:mainfrom
CL-Jeremy:repo-branch-css-3rd-column-nits

Conversation

@CL-Jeremy
Copy link
Copy Markdown
Contributor

  1. The orange label (for "already included in default branch") was left out in Branch page and misc css improvements #15208
  2. The "New Pull Request" button has a right margin that doesn't align with the above labels
  3. Reference links to pull requests should trigger preview pop-ups

This PR fixes the above tiny bits.

I'll try my best to backport this and #15276 now.

CL-Jeremy added a commit to CL-Jeremy/gitea that referenced this pull request Apr 9, 2021
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Apr 9, 2021
@silverwind
Copy link
Copy Markdown
Member

silverwind commented Apr 10, 2021

Reference links to pull requests should trigger preview pop-ups

I think the approach of having to add classes to every link is not ideal. A purely JS-based link detection would surely work better without burdening us to add those classes everywhere. Thought, adding it is fine for now.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 10, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 10, 2021
@lunny
Copy link
Copy Markdown
Member

lunny commented Apr 11, 2021

Could you post a screenshot comparison?

@techknowlogick techknowlogick added this to the 1.15.0 milestone Apr 11, 2021
@zeripath zeripath added backport/v1.14 backport/done All backports for this PR have been created labels Apr 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #15363 (0937248) into main (143071e) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15363      +/-   ##
==========================================
+ Coverage   43.98%   44.02%   +0.04%     
==========================================
  Files         681      681              
  Lines       82230    82230              
==========================================
+ Hits        36168    36202      +34     
+ Misses      40143    40123      -20     
+ Partials     5919     5905      -14     
Impacted Files Coverage Δ
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
routers/repo/view.go 40.66% <0.00%> (-0.59%) ⬇️
modules/notification/mail/mail.go 38.77% <0.00%> (ø)
models/error.go 39.84% <0.00%> (+0.78%) ⬆️
models/notification.go 66.07% <0.00%> (+0.88%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️
services/gitdiff/gitdiff.go 73.76% <0.00%> (+1.41%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/notification/ui/ui.go 65.81% <0.00%> (+1.70%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143071e...0937248. Read the comment docs.

@zeripath zeripath merged commit 793e032 into go-gitea:main May 11, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants