Skip to content

Add ETag header#15370

Merged
techknowlogick merged 14 commits into
go-gitea:masterfrom
KN4CK3R:feature-etag
Apr 12, 2021
Merged

Add ETag header#15370
techknowlogick merged 14 commits into
go-gitea:masterfrom
KN4CK3R:feature-etag

Conversation

@KN4CK3R
Copy link
Copy Markdown
Member

@KN4CK3R KN4CK3R commented Apr 9, 2021

Fixes #13499

Add ETag header to cache control. This saves some cpu cycles on the server side and skips transfers for cached files.

grafik
grafik

Comment thread routers/repo/attachment.go
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 9, 2021
Comment thread routers/repo/attachment.go Outdated
Comment thread modules/httpcache/httpcache.go Outdated
Comment thread modules/httpcache/httpcache.go
Comment thread routers/repo/download.go Outdated
Comment thread modules/httpcache/httpcache.go Outdated
Comment thread modules/httpcache/httpcache.go
Comment thread modules/httpcache/httpcache.go Outdated
Comment thread modules/httpcache/httpcache.go Outdated
Comment thread modules/httpcache/httpcache.go Outdated
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 10, 2021
@silverwind
Copy link
Copy Markdown
Member

Lint is failing

@lunny lunny added the performance/speed performance issues with slow downs label Apr 11, 2021
@lunny lunny added this to the 1.15.0 milestone Apr 11, 2021
@techknowlogick
Copy link
Copy Markdown
Member

🚀

@techknowlogick techknowlogick merged commit a35a5b2 into go-gitea:master Apr 12, 2021
KN4CK3R added a commit to KN4CK3R/gitea that referenced this pull request Apr 20, 2021
* Add ETag header.

* Comply with RFC 7232.

* Moved logic into httpcache.go

* Changed name.

* Lint

* Implemented If-None-Match list.

* Fixed missing header on *

* Removed weak etag support.

* Removed * support.

* Added unit test.

* Lint

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
techknowlogick added a commit that referenced this pull request Apr 20, 2021
* Add ETag header.

* Comply with RFC 7232.

* Moved logic into httpcache.go

* Changed name.

* Lint

* Implemented If-None-Match list.

* Fixed missing header on *

* Removed weak etag support.

* Removed * support.

* Added unit test.

* Lint

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@6543 6543 added the backport/done All backports for this PR have been created label Apr 30, 2021
@KN4CK3R KN4CK3R deleted the feature-etag branch May 7, 2021 06:32
zeripath added a commit to zeripath/gitea that referenced this pull request May 7, 2021
Fix go-gitea#15370

Signed-off-by: Andrew Thornton <art27@cantab.net>
6543 pushed a commit to 6543-forks/gitea that referenced this pull request May 7, 2021
Fix go-gitea#15370

Signed-off-by: Andrew Thornton <art27@cantab.net>
6543 pushed a commit that referenced this pull request May 7, 2021
Fix #15370

Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick pushed a commit that referenced this pull request May 7, 2021
…#15774) (#15775)

* Commit Graph: Pull-Requests should not link to issues (#15734)

Use `/pulls` and simplify code.

* reverse #15734 partial and comment (#15740)

* reverse & comment

* Update templates/repo/graph/commits.tmpl

Co-authored-by: 6543 <6543@obermui.de>

Co-authored-by: zeripath <art27@cantab.net>

* Use pulls in commit graph unless pulls are disabled

Fix #15370

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: KN4CK3R <KN4CK3R@users.noreply.github.com>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/speed performance issues with slow downs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable Browser Caching for RAW view

7 participants