Skip to content

Fix ambiguous argument error on tags #15432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 3 commits into from
Apr 14, 2021
Merged

Fix ambiguous argument error on tags #15432

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
109f2e0
Fix ambiguous argument error on tags
zeripath Apr 12, 2021
4b8c1c6
Merge branch 'master' into fix-get-tag-commit-weirdness
zeripath Apr 13, 2021
1b259f2
Merge branch 'master' into fix-get-tag-commit-weirdness
6543 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions modules/git/repo_commit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,7 @@ func (repo *Repository) GetBranchCommitID(name string) (string, error) {

// GetTagCommitID returns last commit ID string of given tag.
func (repo *Repository) GetTagCommitID(name string) (string, error) {
stdout, err := NewCommand("rev-list", "-n", "1", TagPrefix+name).RunInDir(repo.Path)
if err != nil {
if strings.Contains(err.Error(), "unknown revision or path") {
return "", ErrNotExist{name, ""}
}
return "", err
}
return strings.TrimSpace(stdout), nil
return repo.GetRefCommitID(TagPrefix + name)
}

// ConvertToSHA1 returns a Hash object from a potential ID string
Expand Down