Skip to content

Prevent superfluous response.WriteHeader #15456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 3 commits into from
Apr 14, 2021
Merged

Prevent superfluous response.WriteHeader #15456

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5948e8
Prevent superfluous response.WriteHeader
zeripath Apr 13, 2021
4b1ee2a
Merge branch 'master' into stop-the-superfluous-write-header
lunny Apr 14, 2021
0e88a64
Merge branch 'master' into stop-the-superfluous-write-header
6543 Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions modules/context/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

package context

import "net/http"
import (
"net/http"
)

// ResponseWriter represents a response writer for HTTP
type ResponseWriter interface {
Expand Down Expand Up @@ -60,8 +62,10 @@ func (r *Response) WriteHeader(statusCode int) {
}
r.beforeExecuted = true
}
r.status = statusCode
r.ResponseWriter.WriteHeader(statusCode)
if r.status == 0 {
r.status = statusCode
r.ResponseWriter.WriteHeader(statusCode)
}
}

// Flush flush cached data
Expand Down